Re: [PATCH 3/3] drm/rockchip: vop: Split rk3288-vop into big and lit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/09/2024 11:01, Jonas Karlman wrote:
>>>  	0, 0,
>>> @@ -1245,8 +1253,13 @@ static const struct of_device_id vop_driver_dt_match[] = {
>>>  	  .data = &rk3066_vop },
>>>  	{ .compatible = "rockchip,rk3188-vop",
>>>  	  .data = &rk3188_vop },
>>> +	{ .compatible = "rockchip,rk3288-vop-big",
>>> +	  .data = &rk3288_vop_big },
>>
>> Hm... that's not really needed. Instead of having three compatibles, you
>> could keep "rk3288-vop" as big and then my comment on bindings patch
>> could be ignored (you keep the compatible).
> 
> Thanks, I guess that just adding a new compatible for vop-lit should be
> enough.
> 
> VOP_BIG: rockchip,rk3288-vop
> VOP_LIT: rockchip,rk3288-vop-lit, rockchip,rk3288-vop
> 
> That should ensure backward/forward compatibility with any mix of
> old/new boot-firmware, DTs and kernels.
> 
> Will change to use that in v2.

Yes, thanks.

Best regards,
Krzysztof




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux