On Mon, Sep 23, 2024 at 09:38:59PM GMT, zhaoxiong lv wrote: > On Mon, Sep 23, 2024 at 8:07 PM Dmitry Baryshkov > <dmitry.baryshkov@xxxxxxxxxx> wrote: > > > > On Mon, Sep 23, 2024 at 05:22:20PM GMT, zhaoxiong lv wrote: > > > On Mon, Sep 16, 2024 at 1:15 PM Dmitry Baryshkov > > > <dmitry.baryshkov@xxxxxxxxxx> wrote: > > > > > > > > Same comment as the one that I've provided to the other patch, plus: > > > > > > > > On Sun, 15 Sept 2024 at 10:11, Zhaoxiong Lv > > > > <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > > > In order to meet the timing, remove the delay between "backlight off" > > > > > and "display off", and reduce the delay between "display_off" and > > > > > "enter_sleep" > > > > > > > > Separate commit, separate _justification_. Why, not what. > > > > > > > > > > > > > > Removing variables: display_off_to_enter_sleep_delay_ms > > > > > > > > This phrase is useless. > > > > > > > hi Dmitry > > > > > > As in another patch reply, in order to solve a black screen problem, > > > the delay is reduced. > > > The panel spec: > > > 1. https://github.com/Vme5o/power-on-off-sequential > > > > It should be described in the commit message(s). You have removed one > > delay and added another one. Is that a single fix or two separate fixes? > hi Dmitry > We only modify one of the drivers (starry), and the other driver > (boe_th101mb31ig002) is just to keep the original value. Well, the question was about fixes, not about the drivers. -- With best wishes Dmitry
