On Thu, 12 Sep 2024, Tejas Vipin <tejasvipin76@xxxxxxxxx> wrote: > On 9/12/24 12:49 PM, Thomas Zimmermann wrote: >> Hi >> >> Am 11.09.24 um 20:06 schrieb Tejas Vipin: >>> Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since >>> monitor HDMI information is available after EDID is parsed. Additionally >>> rewrite the code the code to have fewer indentation levels. >> >> The problem is that the entire logic is outdated. The content of cdv_hdmi_detect() should go into cdv_hdmi_get_modes(), the detect_ctx callback should be set to drm_connector_helper_detect_from_ddc() and cdv_hdmi_detect() should be deleted. The result is that ->detect_ctx will detect the presence of a display and ->get_modes will update EDID and other properties. >> >> Do you have a device for testing such a change? >> >> Best regards >> Thomas > > I do not have a device to test this. Reading the rest of the series and > given my circumstances, I do not think I will be continuing with this > patch. *sad trombone* I think we could've made concrete incremental positive changes here, without changing everything about detect and get_modes. BR, Jani. -- Jani Nikula, Intel
