On Sun, Sep 22, 2024 at 4:47 PM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > if (ret) > > return ret; > > + > > ret = nt35510_send_long(nt, dsi, NT35510_P1_SETVCL, > > NT35510_P1_VCL_LEN, > > nt->conf->vcl); > > if (ret) > > return ret; > > + > > ret = nt35510_send_long(nt, dsi, NT35510_P1_BT3CTR, > > NT35510_P1_BT3CTR_LEN, > > nt->conf->bt3ctr); > > if (ret) > > return ret; > > + > > ret = nt35510_send_long(nt, dsi, NT35510_P1_SETVGH, > > NT35510_P1_VGH_LEN, > > nt->conf->vgh); > > I think this part is unrelted and should go in as a separate commit. > Other than that LGTM. Ooops residuals from an earlier patch iteration. I fixed it up while applying the patch. Thanks! Linus Walleij