Hi,
On 21-Sep-24 10:02 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 16, 2024 at 03:18:51PM GMT, tjakobi@xxxxxxxxxxxxxxxxxxxxx wrote:
>> From: Joaquín Ignacio Aramendía <samsagax@xxxxxxxxx>
>>
>> Add quirk orientation for AYA NEO 2. The name appears without spaces in
>> DMI strings. That made it difficult to reuse the 2021 match. Also the
>> display is larger in resolution.
>>
>> Tested by the JELOS team that has been patching their own kernel for a
>> while now and confirmed by users in the AYA NEO and ChimeraOS discord
>> servers.
>>
>> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@xxxxxxxxx>
>> Signed-off-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> index 2166208a961d..3044927c0c5c 100644
>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> @@ -184,6 +184,12 @@ static const struct dmi_system_id orientation_data[] = {
>> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"),
>> },
>> .driver_data = (void *)&lcd800x1280_rightside_up,
>> + }, { /* AYA NEO AYANEO 2 */
>> + .matches = {
>> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
>> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
>> + },
>> + .driver_data = (void *)&lcd1200x1920_rightside_up,
>
> I thought that AYANEO should come after AYADEVICE, but the array doesn't
> seem really sorted
It is sorted but it is sorted by the Vendor - Model in the comments,
not by the DMI strings since sometimes those are e.g. "SYS_VENDOR",
"Default String" and stuff like that.
The entire series looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
for the series.
> Thus:
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
> If I hear no objections and if noone beats me, I'll apply the series
> within few days.
I'm currently travelling so if you can apply this series
to drm-misc-fixes that would be great.
Regards,
Hans
>
>
>> }, { /* AYA NEO 2021 */
>> .matches = {
>> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYADEVICE"),
>> --
>> 2.44.2
>>
>
