On Sat, Aug 31, 2024 at 09:06:41PM GMT, Stephen Boyd wrote:
> Ease driver development by adding stubs for the typec_switch APIs when
> CONFIG_TYPEC=n. Copy the same method used for the typec_mux APIs to be
> consistent.
>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: <linux-usb@xxxxxxxxxxxxxxx>
> Cc: Pin-yen Lin <treapking@xxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> ---
> include/linux/usb/typec_mux.h | 43 +++++++++++++++++++++++++++++++----
> 1 file changed, 38 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/usb/typec_mux.h b/include/linux/usb/typec_mux.h
> index 2489a7857d8e..efb5ed32b813 100644
> --- a/include/linux/usb/typec_mux.h
> +++ b/include/linux/usb/typec_mux.h
> @@ -3,6 +3,7 @@
> #ifndef __USB_TYPEC_MUX
> #define __USB_TYPEC_MUX
>
> +#include <linux/err.h>
> #include <linux/property.h>
> #include <linux/usb/typec.h>
>
> @@ -24,16 +25,13 @@ struct typec_switch_desc {
> void *drvdata;
> };
>
> +#if IS_ENABLED(CONFIG_TYPEC)
> +
> struct typec_switch *fwnode_typec_switch_get(struct fwnode_handle *fwnode);
> void typec_switch_put(struct typec_switch *sw);
> int typec_switch_set(struct typec_switch *sw,
> enum typec_orientation orientation);
>
> -static inline struct typec_switch *typec_switch_get(struct device *dev)
> -{
> - return fwnode_typec_switch_get(dev_fwnode(dev));
> -}
> -
> struct typec_switch_dev *
> typec_switch_register(struct device *parent,
> const struct typec_switch_desc *desc);
> @@ -42,6 +40,41 @@ void typec_switch_unregister(struct typec_switch_dev *sw);
> void typec_switch_set_drvdata(struct typec_switch_dev *sw, void *data);
> void *typec_switch_get_drvdata(struct typec_switch_dev *sw);
>
> +#else
> +
> +static inline struct typec_switch *
> +fwnode_typec_switch_get(struct fwnode_handle *fwnode)
> +{
> + return NULL;
> +}
> +static inline void typec_switch_put(struct typec_switch *sw) {}
> +static inline int typec_switch_set(struct typec_switch *sw,
> + enum typec_orientation orientation)
> +{
> + return 0;
> +}
Just my 2c:
The stubs above look fine from my POV, they help us to cleanup the users
of the API. The register/unregister callbacks are not. The switch
providers should clearly know whether the API is actually available or
not. Compare this to how other subsystems (regulators, interconnects,
etc) provide stubs for consumer API only.
In other words, please consider sending a patch that drops provider-side
Type-C MUX API stubs.
> +
> +static inline struct typec_switch_dev *
> +typec_switch_register(struct device *parent,
> + const struct typec_switch_desc *desc)
> +{
> + return ERR_PTR(-EOPNOTSUPP);
> +}
> +static inline void typec_switch_unregister(struct typec_switch_dev *sw) {}
> +
> +static inline void typec_switch_set_drvdata(struct typec_switch_dev *sw, void *data) {}
> +static inline void *typec_switch_get_drvdata(struct typec_switch_dev *sw)
> +{
> + return ERR_PTR(-EOPNOTSUPP);
> +}
> +
> +#endif /* CONFIG_TYPEC */
> +
> +static inline struct typec_switch *typec_switch_get(struct device *dev)
> +{
> + return fwnode_typec_switch_get(dev_fwnode(dev));
> +}
> +
> struct typec_mux_state {
> struct typec_altmode *alt;
> unsigned long mode;
> --
> https://chromeos.dev
>
--
With best wishes
Dmitry
