Le 16/09/24 - 23:46, YJ Lin a écrit : > Hi Sean and the vkms maintainers: > > I’m Leo, currently one of the mentees of the Linux Kernel Bug Fixing > Program 2024 Summer Unpaid[1]. I saw an item on the DRM TODO list > regarding "Convert logging to drm_* functions with drm_device > parameter"[2]. It also suggests reaching out to the driver maintainers > beforehand. So I’d like to understand your opinions toward making this > conversion on the vkms driver, and I’d like to start working on it if > you consider it suitable. Thank you! Hi Leo, It is very nice to work on this subject, thank you! On the VKMS side, the current upstream driver can only create one instance of the device, but we are working on supporting more, so it definitly make sense to have per-device logging. Feel free to send patches to change this where it make sense. Few series are pending on the mailing list, so feel free to point where we miss this too! (for example [3,4] [3]:https://lore.kernel.org/all/20240912-google-vkms-managed-v3-0-7708d6ad262d@xxxxxxxxxxx/ [4]:https://lore.kernel.org/all/20240912-b4-vkms-allocated-v1-0-29abbaa14af9@xxxxxxxxxxx/ > (Also, do feel free to share tips for DRM and kernel development in general.) Don't hesitate to send documentation patches if you had difficulties to understand stuff, it will profit to everyone. If you need more documentation about VKMS internals, a "big" patch is pending [5]. [5]:https://lore.kernel.org/all/20240905-google-clarifications-v4-1-e43c1f2e3d87@xxxxxxxxxxx/ Thanks, Louis Chauvet > Best, > Leo > > [1] https://mentorship.lfx.linuxfoundation.org/project/9c354ea7-f08e-4d85-a93d-94d2a3cb30c8 > [2] https://www.kernel.org/doc/html/latest/gpu/todo.html#convert-logging-to-drm-functions-with-drm-device-parameter -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com