On 10/09/2024 16:51, Dmitry Baryshkov wrote:
> On Tue, Sep 10, 2024 at 01:03:43PM GMT, Jani Nikula wrote:
>
>> Building with clang and and W=1 leads to warning about unused
>> pll_cmp_to_fdata(). Fix by annotating it with __maybe_unused.
>>
>> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
>> inline functions for W=1 build").
>>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> I think this function can be dropped. Marc, your call, as an author of
> the patch?
( Why is the patch prefixed "drm/msmi", is "msmi" a typo? )
-> For the record, Arnaud is the driver's author.
pll_cmp_to_fdata() was used in hdmi_8998_pll_recalc_rate()
in a commented code block which was later removed.
Thus, yes, it is safe to completely delete the unused function.
I'm surprised gcc didn't catch that...
Regards
>> ---
>> drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
>> index 0e3a2b16a2ce..c0bf1f35539e 100644
>> --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
>> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
>> @@ -153,7 +153,7 @@ static inline u32 pll_get_pll_cmp(u64 fdata, unsigned long ref_clk)
>> return dividend - 1;
>> }
>>
>> -static inline u64 pll_cmp_to_fdata(u32 pll_cmp, unsigned long ref_clk)
>> +static inline __maybe_unused u64 pll_cmp_to_fdata(u32 pll_cmp, unsigned long ref_clk)
>> {
>> u64 fdata = ((u64)pll_cmp) * ref_clk * 10;
>>
>> --
>> 2.39.2
