On Tue, 10 Sep 2024, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> Hi Jani,
>
> On Tue, Sep 10, 2024 at 12:06 PM Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
>> Building with clang and and W=1 leads to warning about unused
>> rcar_cmm_read(). Fix by annotating it with __maybe_unused.
>>
>> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
>> inline functions for W=1 build").
>>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
>> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
>> @@ -32,7 +32,7 @@ struct rcar_cmm {
>> } lut;
>> };
>>
>> -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
>> +static inline __maybe_unused int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
>> {
>> return ioread32(rcmm->base + reg);
>> }
>
> This function was never used. Why not remove it instead?
Can do if that's what the maintainers desire. It's just that sometimes
it's better to have the implementation reviewed and ready waiting for
the users than requiring the first user to add the implementation. I
opted for __maybe_unused across the series.
BR,
Jani.
>
> Gr{oetje,eeting}s,
>
> Geert
--
Jani Nikula, Intel
