Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jocelyn,

kernel test robot noticed the following build warnings:

[auto build test WARNING on e8653e63e834e4c7de60b81b8b24deb7bdd3bf56]

url:    https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-panic-Add-ABGR2101010-support/20240906-180717
base:   e8653e63e834e4c7de60b81b8b24deb7bdd3bf56
patch link:    https://lore.kernel.org/r/20240906100434.1171093-4-jfalempe%40redhat.com
patch subject: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+
config: x86_64-randconfig-121-20240909 (https://download.01.org/0day-ci/archive/20240909/202409091805.3PzxoAY6-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240909/202409091805.3PzxoAY6-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409091805.3PzxoAY6-lkp@xxxxxxxxx/

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/nouveau/dispnv50/wndw.c:651:66: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void [noderef] __iomem *vaddr_iomem @@     got void *virtual @@
   drivers/gpu/drm/nouveau/dispnv50/wndw.c:651:66: sparse:     expected void [noderef] __iomem *vaddr_iomem
   drivers/gpu/drm/nouveau/dispnv50/wndw.c:651:66: sparse:     got void *virtual

vim +651 drivers/gpu/drm/nouveau/dispnv50/wndw.c

   628	
   629	static int
   630	nv50_wndw_get_scanout_buffer(struct drm_plane *plane, struct drm_scanout_buffer *sb)
   631	{
   632		struct drm_framebuffer *fb;
   633		struct nouveau_bo *nvbo;
   634	
   635		if (!plane->state || !plane->state->fb)
   636			return -EINVAL;
   637	
   638		fb = plane->state->fb;
   639		nvbo = nouveau_gem_object(fb->obj[0]);
   640	
   641		/* Don't support compressed format, or multiplane yet. */
   642		if (nvbo->comp || fb->format->num_planes != 1)
   643			return -EOPNOTSUPP;
   644	
   645		if (nouveau_bo_map(nvbo)) {
   646			pr_warn("nouveau bo map failed, panic won't be displayed\n");
   647			return -ENOMEM;
   648		}
   649	
   650		if (nvbo->kmap.bo_kmap_type & TTM_BO_MAP_IOMEM_MASK)
 > 651			iosys_map_set_vaddr_iomem(&sb->map[0], nvbo->kmap.virtual);
   652		else
   653			iosys_map_set_vaddr(&sb->map[0], nvbo->kmap.virtual);
   654	
   655		sb->height = fb->height;
   656		sb->width = fb->width;
   657		sb->pitch[0] = fb->pitches[0];
   658		sb->format = fb->format;
   659	
   660		/* If tiling is enabled, use the set_pixel() to display correctly.
   661		 * Only handle 32bits format for now.
   662		 */
   663		if (fb->modifier & 0xf) {
   664			if (fb->format->cpp[0] != 4)
   665				return -EOPNOTSUPP;
   666			sb->private = (void *) fb;
   667			sb->set_pixel = nv50_set_pixel;
   668		}
   669		return 0;
   670	}
   671	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux