On 8.09.2024 7:59 PM, Dmitry Baryshkov wrote: > Under some circumstance Under what circumstances? This branch is only taken if there's a .create_private_address_space callback and it only seems to be there on a[67]xx. a6xx_create_address_space returns: - an ERR_PTR if msm_iommu_pagetable_create() fails - retval of msm_gem_address_space_create() otherwise - retval of msm_iommu_pagetable_create() is nullchecked here again because we apparently we want to be double sure - err_ptr(-enomem) is returned if allocating aspace fails - otherwise aspace is allocated somewhere Konrad