Hi, >Hi Min Hua, > Thanks for your work > >At 2024-09-06 06:38:50, "Min-Hua Chen" <minhuadotchen@xxxxxxxxx> wrote: >>Include rockchip_drm_drv.h to fix the follow sparse warning: >> >>drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: >>warning: symbol 'vop2_platform_driver' was not declared. >>Should it be static? >> >>No functional change intended. >> >>Signed-off-by: Min-Hua Chen <minhuadotchen@xxxxxxxxx> >>--- >> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1 + >> 1 file changed, 1 insertion(+) >> >>diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c >>index 18efb3fe1c00..c678d1b0fd7c 100644 >>--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c >>+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c >>@@ -14,6 +14,7 @@ >> #include <drm/drm_print.h> >> >> #include "rockchip_drm_vop2.h" >>+#include "rockchip_drm_drv.h" >> > >We already have a patch[0] include rockchip_drm_drv.h in rockchip_drm_vop2.h > >[0]https://patchwork.kernel.org/project/linux-rockchip/patch/20240904120238.3856782-3-andyshrk@xxxxxxx/ that's great, thanks for letting me know. Min-Hua