Hi, On Fri Sep 6, 2024 at 11:50 AM CEST, Andy Yan wrote: > At 2024-09-06 17:28:33, "Diederik de Haas" <didi.debian@xxxxxxxxx> wrote: > >On Fri Sep 6, 2024 at 2:42 AM CEST, Andy Yan wrote: > >> At 2024-09-06 06:38:50, "Min-Hua Chen" <minhuadotchen@xxxxxxxxx> wrote: > >> >Include rockchip_drm_drv.h to fix the follow sparse warning: > >> > > >> >drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: > >> >warning: symbol 'vop2_platform_driver' was not declared. > >> >Should it be static? > >> > > >> >No functional change intended. > >> > > >> >Signed-off-by: Min-Hua Chen <minhuadotchen@xxxxxxxxx> > >> >--- > >> > drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 1 + > >> > 1 file changed, 1 insertion(+) > >> > > >> >diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > >> >index 18efb3fe1c00..c678d1b0fd7c 100644 > >> >--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > >> >+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > >> >@@ -14,6 +14,7 @@ > >> > #include <drm/drm_print.h> > >> > > >> > #include "rockchip_drm_vop2.h" > >> >+#include "rockchip_drm_drv.h" > >> > > >> > >> We already have a patch[0] include rockchip_drm_drv.h in rockchip_drm_vop2.h > >> > >> [0]https://patchwork.kernel.org/project/linux-rockchip/patch/20240904120238.3856782-3-andyshrk@xxxxxxx/ > > > >Maybe I'm missing something, but this patch seems to fix an already > >existing bug (which should have a Fixes tag?), which Andy also fixed > >while implementing a different (and unrelated) feature? > > In fact, I don't know how to reproduce this compilation issue. FWIW: I didn't see it either, but I assumed I was missing the right context (i.e. patches) needed to trigger that warning. > While implementing my feature, I happened to find that I need to > include rockchip_drm_drv.h in rockchip_drm_vop2.h Makes perfect sense :) But if the warning is indeed valid, it should be fixed on its own (IMO). Cheers, Diederik
Attachment:
signature.asc
Description: PGP signature
