On Sat, Aug 31, 2024 at 09:06:56PM -0700, Stephen Boyd wrote:
> +static void cros_typec_inject_hpd(struct cros_typec_data *typec,
> + struct ec_response_usb_pd_mux_info *resp,
> + struct cros_typec_port *port)
> +{
[...]
> + /*
> + * Only read the mux GPIO setting if we need to change the active port.
> + * Otherwise, an active port is already set and HPD going high or low
> + * doesn't change the muxed port until DP mode is exited.
> + */
> + if (!typec->active_dp_port) {
Given that cros_typec_inject_hpd() is called before `typec->active_dp_port`
would be set (from previous patch "platform/chrome: ... Support DP muxing"),
would it possibly wrongly fall into here at the beginning? (E.g.:
cros_typec_probe() -> cros_typec_port_update() -> cros_typec_configure_mux()
-> cros_typec_inject_hpd().)
> [...]
> + /* Inject HPD from the GPIO state if EC firmware is broken. */
> + if (typec->hpd_asserted)
> + resp->flags |= USB_PD_MUX_HPD_LVL;
`typec->hpd_asserted` is shared between all typec->ports[...]. Would it be
possible that a HPD is asserted for another port but not current `port`?
E.g.: cros_typec_inject_hpd() for port 2 and cros_typec_dp_bridge_hpd_notify()
gets called due to port 1 at the same time?
