On Tue, Sep 03, 2024 at 04:05:06PM +0300, Tomi Valkeinen wrote: > Hi, > > On 03/09/2024 14:56, Maxime Ripard wrote: > > On Mon, Sep 02, 2024 at 03:31:28PM GMT, Tomi Valkeinen wrote: > > > Hi, > > > > > > On 02/09/2024 13:50, Daniel Vetter wrote: > > > > On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote: > > > > > Hi, > > > > > > > > > > On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote: > > > > > > On 25/07/2024 14:28, Maxime Ripard wrote: > > > > > > > On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote: > > > > > > > > On 02/07/2024 14:43, Maxime Ripard wrote: > > > > > > > > > Hi Tomi, > > > > > > > > > > > > > > > > > > On Wed, Jun 26, 2024 at 06:53:40PM GMT, Tomi Valkeinen wrote: > > > > > > > > > > On 26/06/2024 18:07, Maxime Ripard wrote: > > > > > > > > > > > On Wed, Jun 26, 2024 at 12:55:39PM GMT, Tomi Valkeinen wrote: > > > > > > > > > > > > On 26/06/2024 11:49, Maxime Ripard wrote: > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Jun 19, 2024 at 12:07:48PM GMT, Tomi Valkeinen wrote: > > > > > > > > > > > > > > From: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx> > > > > > > > > > > > > > > > > > > > > > > > > > > > > When a bridge driver uses devm_mipi_dsi_device_register_full() or > > > > > > > > > > > > > > devm_mipi_dsi_attach(), the resource management is moved to devres, > > > > > > > > > > > > > > which releases the resource automatically when the bridge driver is > > > > > > > > > > > > > > unbound. > > > > > > > > > > > > > > > > > > > > > > > > > > > > However, if the DSI host goes away first, the host unregistration code > > > > > > > > > > > > > > will automatically detach and unregister any DSI peripherals, without > > > > > > > > > > > > > > notifying the devres about it. So when the bridge driver later is > > > > > > > > > > > > > > unbound, the resources are released a second time, leading to crash. > > > > > > > > > > > > > > > > > > > > > > > > > > That's super surprising. mipi_dsi_device_unregister calls > > > > > > > > > > > > > device_unregister, which calls device_del, which in turn calls > > > > > > > > > > > > > devres_release_all. > > > > > > > > > > > > > > > > > > > > > > > > Hmm, right. > > > > > > > > > > > > > > > > > > > > > > > > > If that doesn't work like that, then it's what needs to be fixed, and > > > > > > > > > > > > > not worked around in the MIPI-DSI bus. > > > > > > > > > > > > > > > > > > > > > > > > Well, something causes a crash for both the device register/unregister case > > > > > > > > > > > > and the attach/detach case, and the call stacks and debug prints showed a > > > > > > > > > > > > double unregister/detach... > > > > > > > > > > > > > > > > > > > > > > > > I need to dig up the board and check again why the devres_release_all() in > > > > > > > > > > > > device_del() doesn't solve this. But I can probably only get back to this in > > > > > > > > > > > > August, so it's perhaps best to ignore this patch for now. > > > > > > > > > > > > > > > > > > > > > > > > However, the attach/detach case is still valid? I see no devres calls in the > > > > > > > > > > > > detach paths. > > > > > > > > > > > > > > > > > > > > > > I'm not sure what you mean by the attach/detach case. Do you expect > > > > > > > > > > > device resources allocated in attach to be freed when detach run? > > > > > > > > > > > > > > > > > > > > Ah, never mind, the devres_release_all() would of course deal with that too. > > > > > > > > > > > > > > > > > > > > However, I just realized/remembered why it crashes. > > > > > > > > > > > > > > > > > > > > devm_mipi_dsi_device_register_full() and devm_mipi_dsi_attach() are given a > > > > > > > > > > device which is used for the devres. This device is probably always the > > > > > > > > > > bridge device. So when the bridge device goes away, so do those resources. > > > > > > > > > > > > > > > > > > > > The mipi_dsi_device_unregister() call deals with a DSI device, which was > > > > > > > > > > created in devm_mipi_dsi_device_register_full(). Unregistering that DSI > > > > > > > > > > device, which does happen when the DSI host is removed, does not affect the > > > > > > > > > > devres of the bridge. > > > > > > > > > > > > > > > > > > > > So, unloading the DSI host driver causes mipi_dsi_device_unregister() and > > > > > > > > > > mipi_dsi_detach() to be called (as part of mipi_dsi_host_unregister()), and > > > > > > > > > > unloading the bridge driver causes them to be called again via devres. > > > > > > > > > > > > > > > > > > Sorry, that's one of the things I don't quite get. Both functions are > > > > > > > > > exclusively(?) called from I2C bridges, so the device passed there > > > > > > > > > should be a i2c_client instance, and thus the MIPI-DSI host going away > > > > > > > > > will not remove those i2c devices, only the MIPI-DSI ones, right? > > > > > > > > > > > > > > > > Yes. > > > > > > > > > > > > > > > > > So if we remove the host, the MIPI-DSI device will be detached and > > > > > > > > > removed through the path you were explaing with the i2c client lingering > > > > > > > > > around. And if we remove the I2C device, then devm will kick in and will > > > > > > > > > detach and remove the MIPI-DSI device. > > > > > > > > > > > > > > > > Right. > > > > > > > > > > > > > > > > > Or is it the other way around? That if you remove the host, the device > > > > > > > > > is properly detached and removed, but there's still the devm actions > > > > > > > > > lingering around in the i2c device with pointers to the mipi_dsi_device > > > > > > > > > that was first created, but since destroyed? > > > > > > > > > > > > > > > > > > And thus, if the i2c device ever goes away, we get a use-after-free? > > > > > > > > > > > > > > > > Hmm, I'm not sure I understand what you mean here... Aren't you describing > > > > > > > > the same thing in both of these cases? > > > > > > > > > > > > > > > > In any case, to expand the description a bit, module unloading is quite > > > > > > > > fragile. I do get a crash if I first unload the i2c bridge module, and only > > > > > > > > then go and unload the other ones in the DRM pipeline. But I think module > > > > > > > > unloading will very easily crash, whatever the DRM drivers being used are, > > > > > > > > so it's not related to this particular issue. > > > > > > > > > > > > > > > > In my view, the unload sequence that should be supported (for development > > > > > > > > purposes, not for production) is to start the unload from the display > > > > > > > > controller module, which tears down the DRM pipeline, and going from there > > > > > > > > towards the panels/connectors. > > > > > > > > > > > > > > > > Of course, it would be very nice if the module unloading worked perfectly, > > > > > > > > but afaics fixing all that's related to module unloading would be a > > > > > > > > multi-year project... So, I just want to keep the sequence I described above > > > > > > > > working, which allows using modules while doing driver development. > > > > > > > > > > > > > > FTR, I'm all for supporting module unloading. The discussion above was > > > > > > > about what is broken exactly, so we can come up with a good solution. > > > > > > > > > > > > Does that mean that you're ok with the patch, or that something should be > > > > > > improved? > > > > > > > > > > No, I meant that at the very least the commit log needs to be updated to > > > > > reflect what is actually going on, because at least my understanding of > > > > > it doesn't match what actually happens. > > > > > > > > > > We want a solution to the problem you're facing, but it's not clear to > > > > > me what the problem is exactly at this point, so it's hard to review a > > > > > solution. > > > > > > > > So I haven't looked at the full thing, but I think the proper fix is to > > > > make both detach and unregister cope with being called multiple times. I > > > > think devm_ here is a red herring, the underlying issues is that we can > > > > unregister/detach from two sides: > > > > > > > > - when the host dsi goes away > > > > - when individual dsi devices on a given host go away > > > > > > > > So there needs to be book-keeping and locking to make sure no matter which > > > > order things disappear, we don't try to unregister/detach a dsi device > > > > twice. > > > > > > I think that is what my patch does (for devm_). > > > > > > Some vocabulary first: > > > > > > dsi peripheral device - The device that represents the DSI peripheral. It is > > > a bridge or a panel, and (usually) an i2c or platform device. > > > > > > dsi peripheral driver - The driver handling the dsi peripheral device. > > > > > > dsi device - Runtime created device instance that represents the DSI > > > peripheral. So in my case we have the i2c bridge device, and a dsi device is > > > created for it in the setup code. > > > > > > dsi controller device - A device that has a DSI bus (usually a platform or > > > i2c device, I would guess). > > > > > > dsi controller driver - A driver for the dsi controller device. Creates the > > > dsi host. > > > > > > dsi host - represents the DSI host side, owned by the dsi controller driver. > > > > > > When a dsi peripheral driver uses devm_mipi_dsi_device_register_full() or > > > devm_mipi_dsi_attach(), the dsi device is created and attached to the dsi > > > host. When the dsi peripheral device-driver is unbound, devres will call > > > unregister and detach are called automatically. This works fine. > > > > > > But when the device-driver for the dsi controller is unbound, the dsi > > > controller driver will unregister the dsi host, > > > > I assume that you're talking about: > > https://elixir.bootlin.com/linux/v6.10.7/source/drivers/gpu/drm/drm_mipi_dsi.c#L357 ? > > Yes. > > > > and the unregistration will also unregister and detach the dsi device. > > > > And https://elixir.bootlin.com/linux/v6.10.7/source/drivers/gpu/drm/drm_mipi_dsi.c#L346 ? > > And yes. > > > > But the devres is not told about that. > > > > If my assumptions are correct, device_unregister() will definitely clean > > up the devres resources on that device: > > Yes, and not. Devres cleans up the resources on "that" device, where that > device is the dsi_device. But that is _not_ the one where we registered the > resources. > > > https://elixir.bootlin.com/linux/v6.10.7/source/drivers/base/core.c#L3886 > > > > > So when the dsi peripheral is later unbound, its devres will again > > > unregister and detach. > > > > I guess in this case, only the device resource tied to the i2c client > > device (so dsi device? in your nomenclature) will run. > > No, the i2c client device is the "dsi peripheral device". Say, a DSI video > mode panel that is controlled via i2c. Or ti-sn65dsi86.c bridge (that one > actually uses a auxiliary_device so it's a bit more complex). > > > Or is it that: > > https://elixir.bootlin.com/linux/v6.10.7/source/drivers/gpu/drm/drm_mipi_dsi.c#L250 > > > > Gets tied to the i2c client device, but the host being removed has > > free'd that device already? > > Yes. The devm_mipi_dsi_* functions register the resources (in this case, the > dsi_device itself and the dsi attach) to the i2c client device's devres. > > > > To fix that this patch uses devm_remove_action() to remove the devres > > > action when the host side goes away first. > > > > > > Now, after writing the above, I realized that all this won't help with the > > > non-devm versions: the host side has unregistered and detached the dsi > > > device, but if the dsi peripheral driver calls mipi_dsi_detach() or > > > mipi_dsi_device_unregister(), it will again crash. > > > > > > Handling the attach/detach should be quite easy, and in fact the code > > > already handles it, but it uses WARN_ON() there so that has to go. But > > > attach/detach will crash anyway if the dsi device has already been freed, > > > which happens when the dsi controller driver calls > > > mipi_dsi_device_unregister(). > > > > > > So... The dsi peripheral driver should keep a reference to the dsi device, > > > with get_device()? And then do a put_device() after calling > > > mipi_dsi_device_unregister()? > > > > > > But we don't free the dsi device, it has essentially been disabled without > > > telling the dsi peripheral driver about it, which might cause problems. > > > > Yeah, and the host pointer would be lingering as well. > > > > > I don't know... This doesn't sound correct to me. Probably my patch is just > > > new wrong on top of old wrong. Or maybe I don't quite grasp how this works. > > > > I think we can fix some of them by storing the "parent" device of > > mipi_dsi_device (ie, the i2c client device) that the devm action is > > registered against, and removing the action in > > mipi_dsi_remove_device_fn. > > That is what my patch does. > > But, as Sima replied, there's much more to this. I'll try to look at this at > some point, but, unfortunately, no customer so far (as far as my memory > serves) has ever been interested in module unloading or unbinding the > devices, so... not very high in the todo list =). I think the proper fix isn't too bad. The changes in the dsi code should be fairly small, and for the refcounting fix you only have to add a call to mipi_dsi_put() in all the non-dsi drivers. With that prep work you can then tackle the conversion to a proper device/driver model driver for each non-dsi driver individually, and as needed. And at least the drivers I looked at are practically there already, so for an individual case I don't think it's a horrible amount of work to fix this properly. Still more than your original patch in this thread though. -Sima -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
