On Tue, 3 Sept 2024 at 10:32, Jun Nie <jun.nie@xxxxxxxxxx> wrote: > > Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> 于2024年8月29日周四 18:54写道： > > > > On Thu, 29 Aug 2024 at 13:19, Jun Nie <jun.nie@xxxxxxxxxx> wrote: > > > > > > From: Jonathan Marek <jonathan@xxxxxxxx> > > > > > > For the bonded DSI case, DSC pic_width and timing calculations should use > > > the width of a single panel instead of the total combined width. > > > > What is a "single panel"? Please rephrase the commit message so that > > it reads logically. > > Yeah, it is a bit confusing without the usage case explanation. "single DSI > interface" shall be much better here. Because bonded-DSI can work with > a single panel with 2 DSI, or with 2 panels with one DSI on each panel. Yes, it sounds much better. > > > > > > > > Bonded DSI can be used to drive a single panel having two input > > > channels, or to drive two panels with a input channel on every panel that > > > behave like single panel for display controller. > > > > Missing actual action. See Documentation/process/submitting-patches.rst > > > > > > > > Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx> > > > > As pointed out during internal review, missing Fixes tag. Any reason > > for ignoring it? > > Sorry, it is missed by mistaken. I am just more familiar with > "Signed-off-by" than > "Fixes:" tag, so not sensitive to Fixed tag and miss it when you > mention it. Will > add it. Well, the regular rule of reviews applies: if you don't agree or don't understand, please reply first. -- With best wishes Dmitry
