Hi Shimrra, On 8/30/24 6:21 PM, Shimrra Shai wrote: > Hi, > > I saw Cristian Ciocaltea's proposed basic driver for the Synopsys DW > HDMI QP transmit (TX) facility on the Rockchip RK3588 and noticed that > it had seen some critique and thought I'd help it along a little by > making some of the changes that others had suggested in the discussion > thread. This package is mostly like his(?) original but features the > following changes suggested by Conor Dooley and Heiko Stuebner: Please stop doing this! I appreciate your intention to help, but this is not the proper way of doing it. This is a work-in-progress series and you should have asked before taking over. Please do not interfere with other people's work without having a preliminary agreement with the author(s). Additionally, before submitting any other patches, you should get familiar with the process - see [1] for a starting point. > * Documentation for the device tree bindings specifies the various > clocks explicitly in both the general (synopsys,dw-hdmi-qp.yaml) > and Rockchip-specific (rockchip,rk3588-dw-hdmi-qp.yaml) files. Why? Did you read [2]? > * Changed the compatibles for the RK3588 VO0 and VO1 GRFs in the > Device Trees (rk3588-base.dtsi) to reflect their different natures. This has been already handled - see [3]. > and some of my own changes: > > * Tweaked the driver code slightly - mostly organizational, but also > added a mutex around device access in the dw_hdmi_qp_... method > that was present in the downstream BSP driver which might have been > necessary to prevent thread bugs. > * Improved grammar & punctuation in some of the English on the > Kconfigs and output messages. > > Let me know how you like it. I hope this is suitable enough for kernel > integration as I'd really like to be able to get some of the newest > kernels having video bringup out of the box. That's definitely not suitable as you made lots of other mistakes while preparing the patches, i.e. preserving authorship, missing commit descriptions, SoB tags, etc. Regards, Cristian [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html [2] https://lore.kernel.org/lkml/038073d0-d4b9-4938-9a51-ea2aeb4530f6@xxxxxxxxxxxxx/ [3] https://lore.kernel.org/lkml/20240828-rk3588-vo-grf-compat-v2-0-4db2f791593f@xxxxxxxxxxxxx/
