On 28/08/2024 16:11, Doug Anderson wrote:
Hi, On Wed, Aug 28, 2024 at 2:22 AM Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:+static int boe_tv101wum_ll2_off(struct boe_tv101wum_ll2 *ctx) +{ + struct mipi_dsi_device *dsi = ctx->dsi; + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi }; + + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; + + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + + mipi_dsi_msleep(&dsi_ctx, 70); + + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); + + mipi_dsi_msleep(&dsi_ctx, 20); + + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x04, 0x5a); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x05, 0x5a); + + mipi_dsi_msleep(&dsi_ctx, 150); + + return dsi_ctx.accum_err; +}optional nit: now that the single caller of this function isn't looking at the error code, you could make boe_tv101wum_ll2_off() return "void".
Indeed, I'll spin a v3 with this and you review and apply it
In any case, this looks good. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Thanks! Neil
