On Mon, Aug 12, 2024 at 03:23:11PM +0300, Jani Nikula wrote:
> Instead of just smashing jiffies into a GUID, use guid_gen() to generate
> RFC 4122 compliant GUIDs.
>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
Read a bit the RFC, definitely sounds better than stuffing jiffies into
the guid ...
Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index 39f1dc45004e..38a9a1441e62 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -2700,18 +2700,10 @@ static void drm_dp_mst_queue_probe_work(struct drm_dp_mst_topology_mgr *mgr)
> static bool drm_dp_validate_guid(struct drm_dp_mst_topology_mgr *mgr,
> guid_t *guid)
> {
> - u64 salt;
> - u8 buf[UUID_SIZE];
> -
> if (!guid_is_null(guid))
> return true;
>
> - salt = get_jiffies_64();
> -
> - memcpy(&buf[0], &salt, sizeof(u64));
> - memcpy(&buf[8], &salt, sizeof(u64));
> -
> - import_guid(guid, buf);
> + guid_gen(guid);
>
> return false;
> }
> --
> 2.39.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
