On Mon, 19 Aug 2024 13:25:08 +0200 Mary Guillemard <mary.guillemard@xxxxxxxxxxxxx> wrote: > +/** > + * struct drm_panthor_timestamp_info - Timestamp information > + * > + * Structure grouping all queryable information relating to the GPU timestamp. > + */ > +struct drm_panthor_timestamp_info { > + /** @timestamp_frequency: The frequency of the timestamp timer. */ > + __u64 timestamp_frequency; > + > + /** @current_timestamp: The current timestamp. */ > + __u64 current_timestamp; > + > + /** @timestamp_offset: The offset of the timestamp timer. */ > + __u64 timestamp_offset; I'm not sure we should expose the offset to be honest. It looks like something that's related to suspend/resume which only the kernel needs to know. > +};