On 2024/8/23 2:01, Alex Deucher wrote:
> On Thu, Aug 22, 2024 at 5:20 AM Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote:
>>
>> dcn35_fpga_funcs is not used anywhere, remove it.
>
> This will lead to warnings about unused functions. The fpga specific
> functions should be removed as well. I'd suggest compile testing your
> changes first to catch these types of warnings.
Thank you!, I noticed these warnings later and it is too late, I'll send
out a new version today.
>
> Alex
>
>
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
>> ---
>> v2:
>> - Remove it instead of making it static.
>> ---
>> .../gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
>> index e2d906327e2e..15977c2d256d 100644
>> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
>> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
>> @@ -1068,13 +1068,6 @@ static struct clk_mgr_funcs dcn35_funcs = {
>> .is_ips_supported = dcn35_is_ips_supported,
>> };
>>
>> -struct clk_mgr_funcs dcn35_fpga_funcs = {
>> - .get_dp_ref_clk_frequency = dce12_get_dp_ref_freq_khz,
>> - .update_clocks = dcn35_update_clocks_fpga,
>> - .init_clocks = dcn35_init_clocks_fpga,
>> - .get_dtb_ref_clk_frequency = dcn31_get_dtb_ref_freq_khz,
>> -};
>> -
>> void dcn35_clk_mgr_construct(
>> struct dc_context *ctx,
>> struct clk_mgr_dcn35 *clk_mgr,
>> --
>> 2.34.1
>>
