On 8/22/24 9:21 PM, Akhil P Oommen wrote:
On Tue, Aug 20, 2024 at 11:48:33AM +0100, Connor Abbott wrote:
On Mon, Aug 19, 2024 at 9:31 PM Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx> wrote:
On Thu, Aug 15, 2024 at 08:26:16PM +0200, Antonino Maniscalco wrote:
Some userspace changes are necessary so add a flag for userspace to
advertise support for preemption.
So the intention is to fallback to level 0 preemption until user moves
to Mesa libs with level 1 support for each new GPU? Please elaborate a bit.
-Akhil.
Yes, that's right. My Mesa series fixes L1 preemption and
skipsaverestore by changing some of the CP_SET_MARKER calls and
register programming and introducing CP_SET_AMBLE calls and then
enables the flag on a7xx.
And we want to control L1 preemption per submitqueue because both
freedreno and turnip may not have support ready at the same time?
Antonino, since this is a UAPI update, it is good to have these details
captured in the commit msg for reference.
-Akhil.
Sure I will update the commit message. Anyway that could be a valid
reason but there is also nothing preventing you from loading different
versions of mesa in two different processes so having one globally
enable preemption and break it for the other wouldn't be ideal. It felt
natural to have it per submitqueue.
Best regards,
--
Antonino Maniscalco <antomani103@xxxxxxxxx>
