On Wed, Aug 21, 2024 at 2:33 AM Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote:
>
> The sparse tool complains as follows:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:1071:22: warning:
> symbol 'dcn35_fpga_funcs' was not declared. Should it be static?
>
> This symbol is not used outside of dcn35_clk_mgr.c, so marks it static.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> index e2d906327e2e..818a9b0933a5 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> @@ -1068,7 +1068,7 @@ static struct clk_mgr_funcs dcn35_funcs = {
> .is_ips_supported = dcn35_is_ips_supported,
> };
>
> -struct clk_mgr_funcs dcn35_fpga_funcs = {
> +static struct clk_mgr_funcs dcn35_fpga_funcs = {
> .get_dp_ref_clk_frequency = dce12_get_dp_ref_freq_khz,
> .update_clocks = dcn35_update_clocks_fpga,
> .init_clocks = dcn35_init_clocks_fpga,
This structure is not used and could be removed. Making it static
will create a warning.
Alex
> --
> 2.34.1
>
