Hi Again, Rodrigo,
...
> > Also it looks something is off with the goto paths...
> >
> > That if (0) is also ugly... probably better to use a
> > kobject_put with continue on every failing point as well...
>
> ehehe... I came to like it, to be honest. Besides I like single
> exit paths instead of distributed returns. In this particular
> case we would replcate the same "kobject_put() ... dev_warn()" in
> several places, so that I'm not sure it's better.
>
> If you like more we could do:
>
> for (...) {
> ...
> ...
> /* everything goes fine */
> continue
>
> err_engine:
> kobject_put(...);
> dev_warn(...);
> }
>
> And we avoid using the "if (0)" that you don't like.
BTW, the purpose of the patch is to remove the break and, as I
was at it, I chhanged dev_err/dev_warn.
Refactoring the "if (0)" is a bit out of scope. Right?
Thanks,
Andi
