Am Montag, 19. August 2024, 10:02:23 CEST schrieb Mary Guillemard:
> Extend the uAPI with a new job requirement flag for cycle
> counters. This requirement is used by userland to indicate that a job
> requires cycle counters or system timestamp to be propagated. (for use
> with write value timestamp jobs)
>
> We cannot enable cycle counters unconditionally as this would result in
> an increase of GPU power consumption. As a result, they should be left
> off unless required by the application.
>
> If a job requires cycle counters or system timestamps propagation, we
> must enable cycle counting before issuing a job and disable it right
> after the job completes.
>
> Since this extends the uAPI and because userland needs a way to advertise
> features like VK_KHR_shader_clock conditionally, we bumps the driver
> minor version.
>
> v2:
> - Rework commit message
> - Squash uAPI changes and implementation in this commit
> - Simplify changes based on Steven Price comments
>
> v3:
> - Add Steven Price r-b
> - Fix a codestyle issue
>
> Signed-off-by: Mary Guillemard <mary.guillemard@xxxxxxxxxxxxx>
> Reviewed-by: Steven Price <steven.price@xxxxxxx>
On a rk3588-tiger with matching MESA build and
"RUSTICL_ENABLE=panfrost clpeak"
Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
Without this change, clpeak fails with
clCreateCommandQueue (-35)
I guess this is mainly applicable to the timestamp part, but that is
partially in this commit too.
Heiko
