On 30/07/2024 14:50, Jerome Brunet wrote:
Comment in suspend says TOP is put in suspend, but the register
poke following is actually de-asserting the reset, like in init.
It is doing the opposite of what the comment says.
Align the comment with what the code is doing for now and add
a FIXME note to sort this out later
Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
---
drivers/gpu/drm/meson/meson_dw_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index 2890796f9d49..5cd3264ab874 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
@@ -751,7 +751,7 @@ static int __maybe_unused meson_dw_hdmi_pm_suspend(struct device *dev)
if (!meson_dw_hdmi)
return 0;
- /* Reset TOP */
+ /* FIXME: This actually bring top out reset on suspend, why ? */
meson_dw_hdmi->data->top_write(meson_dw_hdmi,
HDMITX_TOP_SW_RESET, 0);
Yes, this is probably useless and should:
meson_dw_hdmi->data->top_write(meson_dw_hdmi,
HDMITX_TOP_SW_RESET, 0xffff);
but I think it can be safely removed.
Neil
