Hi Krzysztof, Thank you for the patch. On Sun, Aug 18, 2024 at 07:30:02PM +0200, Krzysztof Kozlowski wrote: > Each variable-length property like interrupts or resets must have fixed > constraints on number of items for given variant in binding. The > clauses in "if:then:" block should define both limits: upper and lower. I thought that, when only one of minItems or maxItems was specified, the other automatically defaulted to the same value. I'm pretty sure I recall Rob asking me to drop one of the two in some bindings. Has the rule changes ? Is it documented somewhere ? > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > .../bindings/display/renesas,du.yaml | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml > index c5b9e6812bce..147842b6465a 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -173,6 +173,7 @@ allOf: > - pattern: '^dclkin\.[01]$' > > interrupts: > + minItems: 2 > maxItems: 2 > > resets: > @@ -228,6 +229,7 @@ allOf: > - pattern: '^dclkin\.[01]$' > > interrupts: > + minItems: 2 > maxItems: 2 > > resets: > @@ -281,6 +283,7 @@ allOf: > - pattern: '^dclkin\.[01]$' > > interrupts: > + minItems: 2 > maxItems: 2 > > resets: > @@ -335,6 +338,7 @@ allOf: > - pattern: '^dclkin\.[01]$' > > interrupts: > + minItems: 2 > maxItems: 2 > > resets: > @@ -396,6 +400,7 @@ allOf: > - pattern: '^dclkin\.[012]$' > > interrupts: > + minItems: 3 > maxItems: 3 > > resets: > @@ -460,9 +465,11 @@ allOf: > - pattern: '^dclkin\.[0123]$' > > interrupts: > + minItems: 4 > maxItems: 4 > > resets: > + minItems: 2 > maxItems: 2 > > reset-names: > @@ -489,9 +496,11 @@ allOf: > > renesas,cmms: > minItems: 4 > + maxItems: 4 > > renesas,vsps: > minItems: 4 > + maxItems: 4 > > required: > - clock-names > @@ -531,9 +540,11 @@ allOf: > - pattern: '^dclkin\.[012]$' > > interrupts: > + minItems: 3 > maxItems: 3 > > resets: > + minItems: 2 > maxItems: 2 > > reset-names: > @@ -558,9 +569,11 @@ allOf: > > renesas,cmms: > minItems: 3 > + maxItems: 3 > > renesas,vsps: > minItems: 3 > + maxItems: 3 > > required: > - clock-names > @@ -600,9 +613,11 @@ allOf: > - pattern: '^dclkin\.[013]$' > > interrupts: > + minItems: 3 > maxItems: 3 > > resets: > + minItems: 2 > maxItems: 2 > > reset-names: > @@ -627,9 +642,11 @@ allOf: > > renesas,cmms: > minItems: 3 > + maxItems: 3 > > renesas,vsps: > minItems: 3 > + maxItems: 3 > > required: > - clock-names > @@ -684,6 +701,7 @@ allOf: > > renesas,vsps: > minItems: 1 > + maxItems: 1 > > required: > - clock-names > @@ -719,6 +737,7 @@ allOf: > - pattern: '^dclkin\.[01]$' > > interrupts: > + minItems: 2 > maxItems: 2 > > resets: > @@ -746,9 +765,11 @@ allOf: > > renesas,cmms: > minItems: 2 > + maxItems: 2 > > renesas,vsps: > minItems: 2 > + maxItems: 2 > > required: > - clock-names > @@ -799,6 +820,7 @@ allOf: > > renesas,vsps: > minItems: 2 > + maxItems: 2 > > required: > - clock-names -- Regards, Laurent Pinchart
