Hi Dustin, On 2024-08-17 14:23:42+0000, Dustin Howett wrote: > On Sat, Aug 17, 2024 at 1:59 PM Dustin L. Howett <dustin@xxxxxxxxxx> wrote: > > > > This patch depends on > > 20240812-amdgpu-min-backlight-quirk-v4-0-56a63ff897b7@xxxxxxxxxxxxxx > > > > I have tested these panels on the Framework Laptop 13 AMD with firmware > > revision 3.05 (latest at time of submission). Thanks for the tests and patch! > I apologize for the noise. I built this against Thomas' earlier patch > version and obviously did inadequate testing when he submitted v4. > > I will follow up with a new revision after a little while. > > > > > + .quirk.pwm_min_brightness = 0, > ^^^^^^ > This is clearly incorrect for the updated quirks infrastructure. If you want, I can incorporate your patch directly into my series. This would make the value of the quirk infrastructure in the introducing series clearer and it should be easier for everybody to keep track of the different parts. If you agree, please let me know and either send me your updated patch privately or I can adapt the patch you posted on my own. My plan is to send a new revision tomorrow. Thomas
