On Fri, Aug 9, 2024 at 2:38 PM Ian Forbes <ian.forbes@xxxxxxxxxxxx> wrote:
>
> Handle unlikely ENOMEN condition and other errors in
> vmw_stdu_connector_atomic_check.
>
> Signed-off-by: Ian Forbes <ian.forbes@xxxxxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Fixes: 75c3e8a26a35 ("drm/vmwgfx: Trigger a modeset when the screen moves")
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> index 571e157fe22e9..3223fd278a598 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
> @@ -886,6 +886,10 @@ static int vmw_stdu_connector_atomic_check(struct drm_connector *conn,
> struct drm_crtc_state *new_crtc_state;
>
> conn_state = drm_atomic_get_connector_state(state, conn);
> +
> + if (IS_ERR(conn_state))
> + return PTR_ERR(conn_state);
> +
> du = vmw_connector_to_stdu(conn);
>
> if (!conn_state->crtc)
> --
> 2.34.1
>
Reviewed-by: Zack Rusin <zack.rusin@xxxxxxxxxxxx>
z
