On Thu, Aug 8, 2024 at 4:52 PM Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > sc7180 programs the ubwc settings as 0x1e as that would mean a > highest bank bit of 14 which matches what the GPU sets as well. > > However, the highest_bank_bit field of the msm_mdss_data which is > being used to program the SSPP's fetch configuration is programmed > to a highest bank bit of 16 as 0x3 translates to 16 and not 14. > > Fix the highest bank bit field used for the SSPP to match the mdss > and gpu settings. > > Fixes: 6f410b246209 ("drm/msm/mdss: populate missing data") > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> Reviewed-by: Rob Clark <robdclark@xxxxxxxxx> > --- > drivers/gpu/drm/msm/msm_mdss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index d90b9471ba6f..faa88fd6eb4d 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -577,7 +577,7 @@ static const struct msm_mdss_data sc7180_data = { > .ubwc_enc_version = UBWC_2_0, > .ubwc_dec_version = UBWC_2_0, > .ubwc_static = 0x1e, > - .highest_bank_bit = 0x3, > + .highest_bank_bit = 0x1, > .reg_bus_bw = 76800, > }; > > -- > 2.44.0 >