On Fri, Aug 09, 2024 at 05:13:14PM +0200, Yannick Fertre wrote: > Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduce > new clocks (bus, ref & lvds). Bus clock was separated from lcd clock. > New sources are possible for lcd clock (lvds / ref). > > Signed-off-by: Yannick Fertre <yannick.fertre@xxxxxxxxxxx> > --- > Changes in v2: Rework clock property. > .../bindings/display/st,stm32-ltdc.yaml | 51 +++++++++++++++---- > 1 file changed, 41 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml > index d6ea4d62a2cf..cc578ad9f040 100644 > --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml > +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml > @@ -12,7 +12,9 @@ maintainers: > > properties: > compatible: > - const: st,stm32-ltdc > + enum: > + - st,stm32-ltdc > + - st,stm32mp25-ltdc > > reg: > maxItems: 1 > @@ -23,13 +25,6 @@ properties: > - description: errors interrupt line. > minItems: 1 > > - clocks: > - maxItems: 1 > - > - clock-names: > - items: > - - const: lcd No, keep these at the top-level. Add to the list and add 'minItems: 1'. Then in the if/then schema, just use minItems/maxItems to limit the number of entries. > - > resets: > maxItems: 1 > > @@ -46,11 +41,47 @@ required: > - compatible > - reg > - interrupts > - - clocks > - - clock-names > - resets > - port > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32mp25-ltdc > + then: > + properties: > + clocks: > + maxItems: 4 > + items: > + - description: Lcd Clock > + - description: Bus Clock > + - description: Reference Clock > + - description: Lvds Clock > + clock-names: > + items: > + - const: lcd > + - const: bus > + - const: ref > + - const: lvds > + required: > + - clocks > + - clock-names > + else: > + properties: > + clocks: > + maxItems: 1 > + items: > + - description: Lcd Clock > + clock-names: > + items: > + - const: lcd > + required: > + - clocks > + - clock-names > + > additionalProperties: false > > examples: > -- > 2.34.1 >