Re: [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver
From: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>
Date: Fri, 9 Aug 2024 10:36:22 -0600
Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <min.ma@xxxxxxx>, <max.zhen@xxxxxxx>, <sonal.santan@xxxxxxx>, <king.tam@xxxxxxx>
In-reply-to: <20240805173959.3181199-4-lizhi.hou@amd.com>
References: <20240805173959.3181199-1-lizhi.hou@amd.com> <20240805173959.3181199-4-lizhi.hou@amd.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0

On 8/5/2024 11:39 AM, Lizhi Hou wrote:

+int aie2_max_col = XRS_MAX_COL;
+module_param(aie2_max_col, int, 0600);
+MODULE_PARM_DESC(aie2_max_col, "Maximum column could be used");

I think you selected the wrong type. What happens if someone sets thisto a negative value?

References:
- [PATCH V2 00/10] AMD XDNA driver
  - From: Lizhi Hou
- [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver
  - From: Lizhi Hou

Prev by Date: Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector
Next by Date: Re: [PATCH V2 05/10] accel/amdxdna: Add GEM buffer object management
Previous by thread: [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver
Next by thread: [PATCH V2 06/10] accel/amdxdna: Add command execution
Index(es):
- Date
- Thread

[Index of Archives] [Linux DRI Users] [Linux Intel Graphics] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [XFree86] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86]

Powered by Linux