Hi, On Wed, Aug 07, 2024 at 11:45:53AM +0100, Andi Shyti wrote: > By moving the pfn calculation to the set_address_limits() > function we improve code readability. This way, > set_address_limits() is responsible for calculating all memory > mapping paramenters: "start", "end" and "pfn". > > This suggestion from Jonathan was made during the review of > commit 8bdd9ef7e9b1 ("drm/i915/gem: Fix Virtual Memory mapping > boundaries calculation"), which I liked, but it got lost on the > way. > > Suggested-by: Jonathan Cavitt <Jonathan.cavitt@xxxxxxxxx> > Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> merged to drm-intel-gt-next. Andi