Hi Jerome,
On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
[...]
> + }, {
> + .limit = 297000,
> + .regs = gxbb_3g_regs,
> + .reg_num = ARRAY_SIZE(gxbb_3g_regs)
Just as a side-note: this looked odd when reading for the first time
as I thought that it's a typo (and it should be gxbb_2g97_regs - but
that name is not used).
[...]
> +static const struct meson_dw_hdmi_speed gxl_speeds[] = {
> + {
> + .limit = 371250,
> + .regs = gxl_3g7_regs,
> + .reg_num = ARRAY_SIZE(gxl_3g7_regs)
> + }, {
> + .limit = 297000,
> + .regs = gxl_3g_regs,
> + .reg_num = ARRAY_SIZE(gxl_3g_regs)
> + }, {
> + .limit = 148500,
> + .regs = gxl_def_regs,
> + .reg_num = ARRAY_SIZE(gxl_def_regs)
this is not consistent with what we have above or below so it either
needs to be updated or a comment.
I think this should be called gxl_1g48_regs
> + }, {
> + .regs = gxl_270m_regs,
> + .reg_num = ARRAY_SIZE(gxl_270m_regs)
and this should be called gxl_def_regs
Best regards,
Martin
