On 01/08/2024 11:50, Cristian Ciocaltea wrote: > On 8/1/24 6:37 AM, Rob Herring (Arm) wrote: >> >> On Thu, 01 Aug 2024 05:25:52 +0300, Cristian Ciocaltea wrote: >>> Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 >>> Quad-Pixel (QP) TX controller IP. >>> >>> Since this is a new IP block, quite different from those used in the >>> previous generations of Rockchip SoCs, add a dedicated binding file. >>> >>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> >>> --- >>> .../display/rockchip/rockchip,dw-hdmi-qp.yaml | 188 +++++++++++++++++++++ >>> 1 file changed, 188 insertions(+) >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: > > This is because the referenced synopsys,dw-hdmi-qp.yaml is provided by a > separate patchset: > > https://lore.kernel.org/lkml/20240801-dw-hdmi-qp-tx-v1-1-148f542de5fd@xxxxxxxxxxxxx/ So you made things untestable. No, this must be one patchset. Do not send some library/helper and users of it in separate patchsets. Best regards, Krzysztof
