Hello,
Thank you for reviewing my patch. I received your feedback:
> Are you sure about all of these? Please document them individually and
> put the proof of that in the changelog text.I'd like to clarify a few points to ensure I address your concerns correctly:
1. By "document them individually", do you mean I should submit separate patches for each mutex documentation change?
2. Regarding the "proof" for the changelog text, could you please elaborate on what kind of proof you 're looking for? Should I include:
- References to the code where these mutexes are used?
- Explanations of the race conditions these mutexes prevent?
- Citations from the driver's design documentation (if available)?
3. Is there a preferred format or level of detail you'd like to see in the changelog for each documentation change?
Thank you for your time and assistance.
Regards,
Riyan Dhiman
On Wed, Jul 31, 2024 at 1:14 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
On Wed, Jul 31, 2024 at 01:06:05PM +0530, Riyan Dhiman wrote:
> Adhere to Linux kernel coding style
>
> Reported by checkpatch:
>
> CHECK: mutex definition without comment
>
> Signed-off-by: Riyan Dhiman <riyandhiman14@xxxxxxxxx>
> ---
> drivers/staging/vme_user/vme_bridge.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
> index 9bdc41bb6602..0b1f05944f0d 100644
> --- a/drivers/staging/vme_user/vme_bridge.h
> +++ b/drivers/staging/vme_user/vme_bridge.h
> @@ -28,6 +28,7 @@ struct vme_master_resource {
> struct vme_slave_resource {
> struct list_head list;
> struct vme_bridge *parent;
> + /* Locking for VME slave resources */
Are you sure about all of these? Please document them individually and
put the proof of that in the changelog text.
thanks,
greg k-h
