On Tue, Jul 30, 2024 at 11:58:19PM +0300, Dmitry Baryshkov wrote:
> Hi Abhinav,
>
> On Tue, 30 Jul 2024 at 22:50, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote:
> >
> > Hardware document indicates that widebus is recommended on DP on all
> > MDSS chipsets starting version 5.x.x and above.
> >
> > Follow the guideline and mark widebus support on all relevant
> > chipsets for DP.
> >
> > Fixes: 766f705204a0 ("drm/msm/dp: Remove now unused connector_type from desc")
> > Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
>
> The issues are present in the following commits. Please consider using
> them instead:
>
> Fixes: 757a2f36ab09 ("drm/msm/dp: enable widebus feature for display port")
> Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
>
But are we really fixing any bugs/issues here? While the docs do
recommend widebus, we're effectively enabling more harware/features.
Unless there's a strong reason (which I'm not confident that the commit
message entails), I think we should drop the fixes-tags and just bring
this to 6.12...
Regards,
Bjorn
>
> > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> --
> With best wishes
> Dmitry
