>> … >>> +++ b/drivers/gpu/drm/loongson/loongson_drv.h >>> @@ -0,0 +1,108 @@ >> … >>> +#ifndef __LOONGSON_DRV_H__ >>> +#define __LOONGSON_DRV_H__ >> … >> >> I suggest to omit leading underscores from such identifiers. … > I suggest add this rules to the checkpatch.pl script, … I hope that you would also like to reduce risks according to undefined behaviour another bit. https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37C.Donotdeclareordefineareservedidentifier-AutomatedDetection Regards, Markus
