On Mon, Jul 29, 2024 at 10:00:00PM +0800, WangYuli wrote: > The struct assertion is failed because sparse cannot parse > `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. > GCC's output is still 1-byte-aligned. No harm to memory layout. > > The error can be filtered out by sparse-diff, but sometimes > multiple lines queezed into one, making the sparse-diff thinks > its a new error. I'm trying to aviod this by fixing errors. > > Link: https://lore.kernel.org/all/20230620045919.492128-1-suhui@xxxxxxxxxxxx/ > Fixes: 1721bc1b2afa ("drm/amdgpu: Update VF2PF interface") > Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: wenlunpeng <wenlunpeng@xxxxxxxxxxxxx> > Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx> > --- Thanks for doing this, but these Signed-off-by tags aren't correct. Signed-off-by is like signing a legal document. It came out of the SCO lawsuits. SCO was a scam where SCO claimed that Linux stole their source code and tried to get Linux users to pay licensing fees. (No one stole anything and SCO didn't even own the copyrights to Unix, those belonged to IBM). You could maybe use the Reported-by: or Suggested-by: tags for Su Hui. But the rest of us could just be Cc: Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Cc: wenlunpeng <wenlunpeng@xxxxxxxxxxxxx> Reported-by: Su Hui <suhui@xxxxxxxxxxxx> Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx> regards, dan carpenter
