On 29/07/2024 14:05, Alex Lanzano wrote: >> Under which circumstances would you become interested to apply a statement >> like “guard(mutex)(&smd->tx_mutex);”? >> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/mutex.h#L196 >> > > Ah, I didn't realize guarded mutexes were implemented. That's really > good to know. > > I'd usually use them when it's possible to return before mutex_unlock is > called to avoid goto cleanup logic. But it's probably best to just use them > by default. > > Thanks for the review. Will clean up in v4. <form letter> Feel free to ignore all comments from Markus, regardless whether the suggestion is reasonable or not. This person is banned from LKML and several maintainers ignore Markus' feedback, because it is just a waste of time. </form letter> Best regards, Krzysztof
