On Sun, Jul 28, 2024 at 12:59 AM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Thu, Jul 25, 2024 at 04:32:44PM GMT, Zhaoxiong Lv wrote: > > Move the 11/29 command from enable() to init() function > > > > As mentioned in the patch: > > https://lore.kernel.org/all/20240624141926.5250-2-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > > > Our DSI host has different modes in prepare() and enable() > > functions. prepare() is in LP mode and enable() is in HS mode. > > Since the 11/29 command must also be sent in LP mode, > > so we also move 11/29 command to the init() function. > > > > After moving the 11/29 command to the init() function, > > we no longer need additional delay judgment, so we delete > > variables "exit_sleep_to_display_on_delay_ms" and > > "display_on_delay_ms". > > Won't this result in a garbage being displayed on the panel during > startup? Hi Dmitry We just moved "Exit sleep mode" and "set display on" from the enable() function to the init() function and did not make any other changes. It seems that many drivers also put the "init code" and "Exit sleep mode" in one function. In addition, we briefly tested the kingdisplay_kd101ne3 panel and melfas_lmfbx101117480 panel, and it seems that there is no garbage on the panel. BR > > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > --- > > .../gpu/drm/panel/panel-jadard-jd9365da-h3.c | 59 ++++++++++--------- > > 1 file changed, 32 insertions(+), 27 deletions(-) >
