Applied. Thanks! Alex On Wed, Jul 24, 2024 at 3:38 AM Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote: > > Use existing swap() function rather than duplicating its implementation. > > ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c:17:29-30: WARNING opportunity for swap(). > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9573 > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > --- > .../display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c > index 717536d7bb30..8e68a8094658 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c > +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c > @@ -7,16 +7,12 @@ > > static void sort(double *list_a, int list_a_size) > { > - double temp; > // For all elements b[i] in list_b[] > for (int i = 0; i < list_a_size - 1; i++) { > // Find the first element of list_a that's larger than b[i] > for (int j = i; j < list_a_size - 1; j++) { > - if (list_a[j] > list_a[j + 1]) { > - temp = list_a[j]; > - list_a[j] = list_a[j + 1]; > - list_a[j + 1] = temp; > - } > + if (list_a[j] > list_a[j + 1]) > + swap(list_a[j], list_a[j + 1]); > } > } > } > -- > 2.32.0.3.g01195cf9f >
