Le 15/07/2024 à 15:15, Ilia Mirkin a écrit :
On Mon, Jul 15, 2024 at 7:49 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 15 Jul 2024 13:36:54 +0200
Single characters should be put into a sequence.
Thus use the corresponding function “seq_putc” for one selected call.
This issue was transformed by using the Coccinelle software.
Suggested-by: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
index e83db051e851..931b62097366 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -42,7 +42,7 @@ nouveau_debugfs_vbios_image(struct seq_file *m, void *data)
int i;
for (i = 0; i < drm->vbios.length; i++)
- seq_printf(m, "%c", drm->vbios.data[i]);
+ seq_putc(m, drm->vbios.data[i]);
Is there some reason this whole thing isn't just
seq_write(m, drm->vbios.data, drm->vbios.length)
Hi,
I don't know if my answer is relevant or not here but:
for () seq_putc(); ==> will fill 'm' with everything that fits in
and
seq_write() ==> is all or nothing. So if 'm' is too small, then
nothing will be appended.
I've not looked at the calling tree, but I would expect 'm' to be able
to have PAGE_SIZE chars, so most probably 4096.
And having gpu + "vbios.rom", I would expect it to be bigger than 4096.
If I'm correct, then changing for seq_write() would just show... nothing.
I don't know if it can happen., but testing should be easy enough to
figure it out.
just my 2c.
CJ
return 0;
}
--
2.45.2
