On 21.07.2024 11:43 PM, Barnabás Czémán wrote: > On Sat, Jun 22, 2024 at 1:36 PM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: >> >> On 20.06.2024 11:52 PM, Barnabás Czémán wrote: >>> From: Otto Pflüger <otto.pflueger@xxxxxxxxx> >>> >>> Add support for Adreno 306A GPU what is found in MSM8917 SoC. >>> This GPU marketing name is Adreno 308. >>> >>> Signed-off-by: Otto Pflüger <otto.pflueger@xxxxxxxxx> >>> [use internal name of the GPU, reword the commit message] >>> Signed-off-by: Barnabás Czémán <trabarni@xxxxxxxxx> >>> --- >>> Changes in v2: >>> - Rebase on https://patchwork.freedesktop.org/series/127393/ >>> - Link to v1: https://lore.kernel.org/r/20240528-a306a-v1-1-03a66dacd8c7@xxxxxxxxx >>> --- [...] >>> drivers/gpu/drm/msm/adreno/a3xx_catalog.c | 11 +++++++++++ >>> drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 14 +++++++++++--- >>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 6 ++++++ >>> 3 files changed, 28 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/msm/adreno/a3xx_catalog.c b/drivers/gpu/drm/msm/adreno/a3xx_catalog.c >>> index 0de8465b6cf0..61aeac5054a2 100644 >>> --- a/drivers/gpu/drm/msm/adreno/a3xx_catalog.c >>> +++ b/drivers/gpu/drm/msm/adreno/a3xx_catalog.c >>> @@ -41,6 +41,17 @@ static const struct adreno_info a3xx_gpus[] = { >>> .gmem = SZ_128K, >>> .inactive_period = DRM_MSM_INACTIVE_PERIOD, >>> .init = a3xx_gpu_init, >>> + }, { >>> + .chip_ids = ADRENO_CHIP_IDS(0x03000620), >>> + .family = ADRENO_3XX, >>> + .revn = 308, >> >> Double space > It is similar like other blocks. Feel free to correct it there as well [...] >>> >>> +static inline bool adreno_is_a306a(const struct adreno_gpu *gpu) >>> +{ >>> + /* a306a marketing name is a308 */ >> >> "marketing name is a308" could use a (), but it's me being picky.. > /* a306a (marketing name is a308) */ ? yes Konrad
