> The AI Engine consists of 2D array of tiles arranged as columns. The > resource solver provides the interfaces to manage allocation of the tile > columns for a hardware context. The basic column allocation and release > functions are provided. Can such a change description be improved with imperative wordings? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94 … > +++ b/drivers/accel/amdxdna/aie2_solver.c > @@ -0,0 +1,329 @@ … > +void *xrsm_init(struct init_config *cfg) > +{ … > + memcpy(&xrs->cfg, cfg, sizeof(struct init_config)); … Please specify a pointer “dereference” instead of the data structure name. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.10#n953 Regards, Markus
