On 7/19/24 09:54, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > The added lvds driver and a change in the dsi driver resulted in failed > builds when COMMON_CLK is disabled: > > x86_64-linux-ld: drivers/gpu/drm/stm/dw_mipi_dsi-stm.o: in function `dw_mipi_dsi_stm_remove': > dw_mipi_dsi-stm.c:(.text+0x51e): undefined reference to `clk_hw_unregister' > > x86_64-linux-ld: drivers/gpu/drm/stm/lvds.o: in function `lvds_remove': > lvds.c:(.text+0xe3): undefined reference to `of_clk_del_provider' > x86_64-linux-ld: lvds.c:(.text+0xec): undefined reference to `clk_hw_unregister' > x86_64-linux-ld: drivers/gpu/drm/stm/lvds.o: in function `lvds_pll_config': > lvds.c:(.text+0xb5d): undefined reference to `clk_hw_get_rate' > x86_64-linux-ld: drivers/gpu/drm/stm/lvds.o: in function `lvds_probe': > lvds.c:(.text+0x1476): undefined reference to `clk_hw_register' > x86_64-linux-ld: lvds.c:(.text+0x148b): undefined reference to `of_clk_hw_simple_get' > x86_64-linux-ld: lvds.c:(.text+0x1493): undefined reference to `of_clk_add_hw_provider' > x86_64-linux-ld: lvds.c:(.text+0x1535): undefined reference to `clk_hw_unregister' > > Add this as a dependency for the stm driver itself, since it will be > required in practice anyway. > > Fixes: 185f99b61442 ("drm/stm: dsi: expose DSI PHY internal clock") > Fixes: aca1cbc1c986 ("drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Hi Arnd I've applied your patch to the drm-misc-next. Thanks, Raphaël