Re: [PATCH 1/2] drm/i915/arl: Enable Wa_14019159160 for ARL

["Belgaumkar, Vinay" <vinay.belgaumkar@xxxxxxxxx>]

On 6/21/2024 5:46 PM, John.C.Harrison@xxxxxxxxx wrote:
> From: John Harrison <John.C.Harrison@xxxxxxxxx>
>
> The context switch out workaround also applies to ARL.
>
> Signed-off-by: John Harrison <John.C.Harrison@xxxxxxxxx>

LGTM,

Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@xxxxxxxxx>

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc.c     | 2 +-
>   drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 5e60a34692af8..097fc6bd1285e 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -296,7 +296,7 @@ static u32 guc_ctl_wa_flags(struct intel_guc *guc)
>   
>   	/* Wa_16019325821 */
>   	/* Wa_14019159160 */
> -	if (IS_GFX_GT_IP_RANGE(gt, IP_VER(12, 70), IP_VER(12, 71)))
> +	if (IS_GFX_GT_IP_RANGE(gt, IP_VER(12, 70), IP_VER(12, 74)))
>   		flags |= GUC_WA_RCS_CCS_SWITCHOUT;
>   
>   	/*
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
> index 7995f059f30df..f1fe5f9054538 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
> @@ -850,7 +850,7 @@ static void guc_waklv_init(struct intel_guc *guc)
>   	remain = guc_ads_waklv_size(guc);
>   
>   	/* Wa_14019159160 */
> -	if (IS_GFX_GT_IP_RANGE(gt, IP_VER(12, 70), IP_VER(12, 71)))
> +	if (IS_GFX_GT_IP_RANGE(gt, IP_VER(12, 70), IP_VER(12, 74)))
>   		guc_waklv_enable_simple(guc,
>   					GUC_WORKAROUND_KLV_SERIALIZED_RA_MODE,
>   					&offset, &remain);