On 10.07.2024 7:05 PM, Stephan Gerhold wrote: > The backlight does not work correctly with the current display panel > configuration: It works after boot, but once the display gets disabled it > is not possible to get it back on. It turns out that the ATNA45AF01 panel > needs exactly the same non-standard power sequence as implemented by the > panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. > > Switch the panel in the DT to the new compatible and make two more changes > to make it work correctly: > > 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and > enable-gpios in the DT). > 2. Drop the regulator-always-on for the panel regulator. The panel does > not seem to power off properly if the regulator stays on. > > Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx> > --- [...] > + power-source = <1>; /* 1.8V */ Would be nice to get the #defines for this PMIC instead.. > + input-disable; > + output-enable; LGTM otherwise Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad
