Hello everyone,
Thank you a lot for your prompt feedbacks.
I'm really sorry for all the mistakes, it is the first time that I try to submit a patch and i thought I followed the guideline but clearly that was not the case.
@Marek Vasut About your question to why disabling burst-mode:
- I agree with you that Burst Mode is the preferred way to send data. For that reason I created the new flag in a way that, if not used in dts, burst mode remains active by default.
Thank you a lot for your prompt feedbacks.
I'm really sorry for all the mistakes, it is the first time that I try to submit a patch and i thought I followed the guideline but clearly that was not the case.
@Marek Vasut About your question to why disabling burst-mode:
- I agree with you that Burst Mode is the preferred way to send data. For that reason I created the new flag in a way that, if not used in dts, burst mode remains active by default.
However, I decide to introduced this property because I have noticed that some dual-channel panels work better in non-burst mode (even if less efficient), and since the sn65dsi84 datasheet allows this setting, I thought to give this opportunity to users.
What do you think about it?
After reading better the documentation, I understood that I have to send a Patch Series that includes binding documentation, the implementation and a cover letter. Is that correct? Should I start a new thread or should I continue this one?
Thank you very much for your support and your patience,
Best regards,
Stefano
What do you think about it?
After reading better the documentation, I understood that I have to send a Patch Series that includes binding documentation, the implementation and a cover letter. Is that correct? Should I start a new thread or should I continue this one?
Thank you very much for your support and your patience,
Best regards,
Stefano
Il giorno lun 8 lug 2024 alle ore 18:47 Rob Herring (Arm) <robh@xxxxxxxxxx> ha scritto:
On Mon, 08 Jul 2024 17:18:56 +0200, stefano.radaelli21@xxxxxxxxx wrote:
> From: Stefano Radaelli <stefano.radaelli21@xxxxxxxxx>
>
> It allows to disable Burst video mode
>
> Co-developed-by: Noah J. Rosa <noahj.rosa@xxxxxxxxx>
> Signed-off-by: Noah J. Rosa <noahj.rosa@xxxxxxxxx>
> Signed-off-by: Stefano Radaelli <stefano.radaelli21@xxxxxxxxx>
> ---
> .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml: burst-mode-disabled: missing type definition
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240708151857.40538-1-stefano.radaelli21@xxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
