Hi, Just two more comments and we are good to go. On 09.07.2024 02:25, Alexander F. Lent wrote: > +/* Add module metadata for the production firmware paths. > + * This needs to be kept in sync with fw_names above. > + */ I would prefer: /* Production fw_names from the table above */ > +MODULE_FIRMWARE("intel/vpu/vpu_37xx_v0.0.bin"); > +MODULE_FIRMWARE("intel/vpu/vpu_37xx_v0.0.bin"); You probably meant *40xx*. Regards, Jacek